agence104 / livekit-server-sdk-php

PHP Server SDK to LiveKit
Apache License 2.0
41 stars 16 forks source link

fix: declare strong type for null apikey and apisecret #13

Closed shakaran closed 4 months ago

shakaran commented 8 months ago

Force strong type via constructor and attributes declaration. Avoid inconsitences with null values allowed in contructor

p-delorme commented 8 months ago

Thanks for the PR @shakaran. With this said, I might actually restructure this class to BaseServiceClass to make it easier and have less code duplication.

shakaran commented 8 months ago

@p-delorme as you want it. We have other possible PR to suggest to improve unit test and code. Also using phpstan, rector, php-cs-fixer and others in default pipeline

p-delorme commented 4 months ago

I've updated all these types in the constructors.

I'll close this, feel free to reopen if you wish.