Closed shakaran closed 4 months ago
Thanks for the PR @shakaran. With this said, I might actually restructure this class to BaseServiceClass to make it easier and have less code duplication.
@p-delorme as you want it. We have other possible PR to suggest to improve unit test and code. Also using phpstan, rector, php-cs-fixer and others in default pipeline
I've updated all these types in the constructors.
I'll close this, feel free to reopen if you wish.
Force strong type via constructor and attributes declaration. Avoid inconsitences with null values allowed in contructor