search

agency-of-learning / conference-app

1 stars 0 forks source link

Live Image Preview #117

Closed ShamiTomita closed 1 year ago

ShamiTomita commented 1 year ago

Ticket/Issue, What does this resolve?

Resolves #109

Description

This PR adds a "dummy" element that is switched out for the user profile photo and changes the onboaring JS controller into the preview controller. When a photo is submitted, the dummy and preview targets swap visibility, and since both are nested in the label block for the input, they can be interchanged.

QA Notes and Testing

Screenshot/Video

Onboarding Form:

https://github.com/agency-of-learning/conference-app/assets/70528966/832e7a3c-564a-4676-9069-d7d0f94aa1ef

User/Registration Edit:

https://github.com/agency-of-learning/conference-app/assets/70528966/8b9fa6c4-315b-4db3-8c56-debbba55d7e8

Feelings gif (optional)

cnorm35 commented 1 year ago

@ShamiTomita is this one meant to replace #113 ?

ShamiTomita commented 1 year ago

@ShamiTomita is this one meant to replace #113 ?

meant to replace part of it lol