agency-of-learning / conference-app

1 stars 0 forks source link

Any Host For Social Media Link #128

Closed ShamiTomita closed 1 year ago

ShamiTomita commented 1 year ago

Ticket/Issue, What does this resolve?

Status 09/23 This ticket is currently WIP, so far I have added '.social' to the allowable hosts which should be able to allow mastodon urls like "ruby.social" or "whatever.social". However, other types of mastodon urls that do not have ".social" are not being accepted.

UPDATE 9/24 So validating the url host seems to be a lot more complicated than I had anticipated. So now I think the social media host should just accept anything. Now the validation just checks if there is proper https format and a host. And I guess we'll trust our users to behave for now... I'm wondering if we should put a warning when they click the icon?

validates :twitter, url: { host: /.\Z/}

Screenshot/Video

https://github.com/agency-of-learning/conference-app/assets/70528966/93100fd2-42f3-452c-9d01-9698aa7740a5

Feelings gif (optional)