search

agencyenterprise / finger-tapping-fnirs-to-nwb

Convert an fNIRS dataset for a finger tapping task to NWB format
BSD 3-Clause "New" or "Revised" License
1 stars 0 forks source link

Add /nirs(i)/StudyDescription upstream in tapping repo? #5

Open rob-luke opened 3 years ago

rob-luke commented 3 years ago

This is amazing and is going to be the basis for how I structure all my projects from now on. I love it.

Something I could do is add the optional SNIRF tag /nirs(i)/StudyDescription and then this could be mapped to NWB EXPERIMENT_DESCRIPTION. Worth me changing/adding this upstream?

dsleiter commented 3 years ago

Happy to hear you like the structure!

Our plan for this repo is that it will stay focused purely on converting and preparing your finger-tapping dataset for the DANDI archive, rather than generalizing. However, we do plan to take what we learned here and extract out a generalized SNIRF -> NWB conversion library.

I think adding StudyDescription to SNIRF files going forward is a great idea, and would be perfect for the conversion library. If you want to do that to your BIDS finger-tapping dataset, then I'm happy to update in order to read from that field here as well. But no pressure from us on updating the dataset just to add the field since we already have written to the NWB files.

rob-luke commented 3 years ago

Cool I wont rush to do it then. But I will make sure I start populating this field in other datasets. Cheers.

dsleiter commented 3 years ago

Sounds good!