The three data types which inherit from DynamicTables (NIRSSourcesTable, NIRSDetectorsTable, and NIRSChannelsTable) have a defined name in the specification, but have a different default name used for class initialization.
Either of the following should be implemented:
the spec should define default_name instead of name and update the default in the class initializer to have the same default value.
the table constructors should not accept a name parameter and instead directly assign the name from the spec
The tentative approach we've discussed is to:
immediately implement 1.
in a future issue, create a utility function to build a NIRSDevice along with the three tables with fixed names, as well as utility functions to add rows to each of the tables
The three data types which inherit from DynamicTables (NIRSSourcesTable, NIRSDetectorsTable, and NIRSChannelsTable) have a defined
namein the specification, but have a different default name used for class initialization.Either of the following should be implemented:
default_nameinstead ofnameand update the default in the class initializer to have the same default value.nameparameter and instead directly assign the name from the specThe tentative approach we've discussed is to: