agencyenterprise / ndx-nirs

An NWB extension for storing Near-Infrared Spectroscopy (NIRS) data
BSD 3-Clause "New" or "Revised" License
5 stars 2 forks source link

Improve how units of measurement are stored #7

Open dsleiter opened 3 years ago

dsleiter commented 3 years ago

Currently, units of measurement are fixed and specified in spec descriptions. However, a better option would be to include them as attributes with default values on specific data channels. This would make the unit of measurement more clear while also being modifiable.

Initially, we tried to include them as attributes, but ran into challenges adding attributes to column datasets of DynamicTables. It seems like this is feasible by create a custom ObjectMapper, but that was left out-of-scope for the hackathon work so it wasn't implemented.