eudesf
commented
1 year ago With the code changes from this PR the arguments are passed to the processes, but with no modifications to the config files we have a crash, as the default
settings.yamldoesn't contain the content required by the decoder and the center out reach task.We also miss user documentation mentioning that a user can pass arguments to this script and we also miss some CLI documentation, like the following:
encoder --help usage: encoder [-h] [--settings-path SETTINGS_PATH] Run encoder. optional arguments: -h, --help show this help message and exit --settings-path SETTINGS_PATH Path to the settings.yaml file.Before proceeding with this changes I would like to discuss if this solution (sending the same arguments to all processes) is better than allowing the user to send specific arguments to each process
@NewtonSander please check again! I've included specific parameters for each process started. :)
codecov-commenter
Introduction
Fixes argument passing to
run_closed_loopscript, so parameters like--settings-pathcan get passed through.Changes
This change sends all the arguments received on
run_closed_loopscript to the started modules subprocesses so they can be read and handled accordingly.Behavior
The
--settings-pathparameter is being ignored onrun_closed_loopscript. With this change, that parameter and any other parameter passed will be captured and handled.