Closed eudesf closed 1 year ago
Patch and project coverage have no change.
Comparison is base (
4fb8ffa
) 86.99% compared to head (0c58d07
) 86.99%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
@NewtonSander I just found that the os.mkfifo()
doesn't work on Windows. I will switch to os.pipe()
then.
@eudesf I made some changes in a forked branch, could you check it? https://github.com/agencyenterprise/neural-data-simulator/blob/run_closed_loop_subprocess_cleanup2/src/tasks/run_closed_loop.py
@eudesf I made some changes in a forked branch, could you check it? https://github.com/agencyenterprise/neural-data-simulator/blob/run_closed_loop_subprocess_cleanup2/src/tasks/run_closed_loop.py
Thanks for creating an example!
But I think we got into the same problem of function scoping or naming. Have you noticed that the _wait_for_center_out_reach_to_finish
can actually finish leaving the center_out_reach
process still running without raising any exception as if it finished successfully? And we are checking on check on line 115 to see if it's still running, which is kinda confusing as you already waited for it.
Introduction
Abrupt termination of
run_closed_loop
with Ctrl+C can leave LSL streams undeleted and processes running in the background. Also, when thecenter_out_reach
script terminates the main experiment task, the streams are still running while the metrics window "Velocities overview" is showing.Changes
run_closed_loop
andcenter_out_reach
to signal the end of the main task, so therun_closed_loop
script can finalize the other running subprocesses.Behavior
On
run_closed_loop
: