search

agencyenterprise / neural-data-simulator

Electrophysiology data simulator for developing brain-computer interfaces
https://agencyenterprise.github.io/neural-data-simulator/
Apache License 2.0
69 stars 7 forks source link

Fix for run_closed_loop on Windows #23

Closed eudesf closed 1 year ago

eudesf commented 1 year ago

Introduction

Running run_closed_loop with poetry on Windows without the extras package installed fails.

Changes

Adds the shell=True parameter so Windows can use the PATH to locate and run the scripts in poetry virtualenv. Also, as the scripts use the shebang they need the cmd shell on Windows to run properly.

Behavior

Now it's possible to run run_closed_loop on Windows with or without installing the extras and using your local environment.

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage has no change and project coverage change: +0.31% :tada:

Comparison is base (eaa7097) 86.68% compared to head (d4e135b) 86.99%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #23 +/- ## ========================================== + Coverage 86.68% 86.99% +0.31% ========================================== Files 21 21 Lines 1667 1707 +40 ========================================== + Hits 1445 1485 +40 Misses 222 222 ``` [see 5 files with indirect coverage changes](https://app.codecov.io/gh/agencyenterprise/neural-data-simulator/pull/23/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=agencyenterprise)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.