Closed charlesbmi closed 1 year ago
Attention: 4 lines
in your changes are missing coverage. Please review.
Files | Coverage Δ | |
---|---|---|
...ural_data_simulator/scripts/run_ephys_generator.py | 87.09% <ø> (ø) |
|
src/neural_data_simulator/ephys_generator.py | 74.92% <83.33%> (+0.08%) |
:arrow_up: |
:loudspeaker: Thoughts on this report? Let us know!.
https://github.com/agencyenterprise/neural-data-simulator/issues/30
Introduction
User feedback:
This is a common use-case: the user may not want to use the compute-power to simulate full-bandwidth ephys signals and may only be interested in the spike times.
Changes
Spikes
class into aSpikeTimes
-generator class (no waveforms) and aWaveforms
-loading class (already defined)pytest
tests as neededBehavior
pytest
and runningrun_closed_loop
locally/SpikeTimes
generator class without definingWaveforms