agencyenterprise / neural-data-simulator

Electrophysiology data simulator for developing brain-computer interfaces
https://agencyenterprise.github.io/neural-data-simulator/
Apache License 2.0
71 stars 7 forks source link

Bump pyright version and fix pyright errors #38

Closed charlesbmi closed 1 year ago

charlesbmi commented 1 year ago

https://github.com/agencyenterprise/neural-data-simulator/issues/37

Introduction

pyright recommends auto-updating to the latest version through the command-line variable. I had this set on my laptop, so make lint was surfacing errors caught by the latest pyright.

Changes

Behavior

codecov-commenter commented 1 year ago

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Files Coverage Δ
src/neural_data_simulator/ephys_generator.py 74.83% <ø> (ø)
src/neural_data_simulator/inputs.py 94.73% <100.00%> (ø)
src/neural_data_simulator/outputs.py 86.38% <ø> (ø)
src/neural_data_simulator/filters.py 66.10% <0.00%> (ø)

:loudspeaker: Thoughts on this report? Let us know!.

charlesbmi commented 1 year ago

(This line that is marked as Codecov as 0% tested is simply a function call that was split amongst more lines due to line length - would be good to add a unit test for the function in the future, but it's not directly in-scope for this PR)

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Files Coverage Δ
src/neural_data_simulator/ephys_generator.py 74.83% <ø> (ø)
src/neural_data_simulator/inputs.py 94.73% <100.00%> (ø)
src/neural_data_simulator/outputs.py 86.38% <ø> (ø)
src/neural_data_simulator/filters.py 66.10% <0.00%> (ø)
📢 Thoughts on this report? Let us know!.