Closed charlesbmi closed 1 year ago
Attention: 1 lines
in your changes are missing coverage. Please review.
Files | Coverage Δ | |
---|---|---|
src/neural_data_simulator/ephys_generator.py | 74.83% <ø> (ø) |
|
src/neural_data_simulator/inputs.py | 94.73% <100.00%> (ø) |
|
src/neural_data_simulator/outputs.py | 86.38% <ø> (ø) |
|
src/neural_data_simulator/filters.py | 66.10% <0.00%> (ø) |
:loudspeaker: Thoughts on this report? Let us know!.
(This line that is marked as Codecov as 0% tested is simply a function call that was split amongst more lines due to line length - would be good to add a unit test for the function in the future, but it's not directly in-scope for this PR)
Codecov Report
Attention:
1 lines
in your changes are missing coverage. Please review.Files Coverage Δ
src/neural_data_simulator/ephys_generator.py74.83% <ø> (ø)
src/neural_data_simulator/inputs.py94.73% <100.00%> (ø)
src/neural_data_simulator/outputs.py86.38% <ø> (ø)
src/neural_data_simulator/filters.py66.10% <0.00%> (ø)
📢 Thoughts on this report? Let us know!.
https://github.com/agencyenterprise/neural-data-simulator/issues/37
Introduction
pyright
recommends auto-updating to the latest version through the command-line variable. I had this set on my laptop, somake lint
was surfacing errors caught by the latestpyright
.Changes
pyright
to latest version:1.1.329
Behavior
src/tasks/center_out_reach/task_window.py
, which now properly rounds pixel coordinates toint
instead of passingfloat
values topygame
.