agencyenterprise / neurotechdevkit

Neurotech Development Kit (NDK)
https://agencyenterprise.github.io/neurotechdevkit/
Apache License 2.0
117 stars 10 forks source link

Compiling problem on render_layout if it was not compiled previously #124

Closed NewtonSander closed 1 year ago

NewtonSander commented 1 year ago

Introduction

With the changes made on PR https://github.com/agencyenterprise/neurotechdevkit/pull/82 the problem is only compiled when a simulation is executed, and not when the scenario is created. This prevents the render_layout function from being called before a simulation was executed.

Changes

The render_layout function is now compiling the problem if it was not compiled before

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage has no change and project coverage change: -0.15 :warning:

Comparison is base (f3efe05) 73.62% compared to head (a2b96a8) 73.47%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #124 +/- ## ========================================== - Coverage 73.62% 73.47% -0.15% ========================================== Files 27 27 Lines 2051 2055 +4 ========================================== Hits 1510 1510 - Misses 541 545 +4 ``` | [Impacted Files](https://app.codecov.io/gh/agencyenterprise/neurotechdevkit/pull/124?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=agencyenterprise) | Coverage Δ | | |---|---|---| | [src/neurotechdevkit/scenarios/\_base.py](https://app.codecov.io/gh/agencyenterprise/neurotechdevkit/pull/124?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=agencyenterprise#diff-c3JjL25ldXJvdGVjaGRldmtpdC9zY2VuYXJpb3MvX2Jhc2UucHk=) | `78.73% <0.00%> (-1.02%)` | :arrow_down: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.