search

agencyenterprise / neurotechdevkit

Neurotech Development Kit (NDK)
https://agencyenterprise.github.io/neurotechdevkit/
Apache License 2.0
115 stars 10 forks source link

Specify `stride` version or commit-hash #142

Closed charlesbmi closed 11 months ago

charlesbmi commented 1 year ago

Issue

The current docs instruct users to install stride from the Github repository: https://github.com/trustimaging/stride . This provides NDK users with the newest stride version, with a (slight) chance that stride updates break something in NDK.

For better reproducibility, we should document/specify (e.g., via poetry.lock) the used stride version.

This is particularly relevant to replicating benchmark simulations, such as https://github.com/agencyenterprise/neurotechdevkit/issues/88 and https://github.com/agencyenterprise/neurotechdevkit/issues/89

charlesbmi commented 11 months ago

FYI, this caused an issue with a recent PR: https://github.com/agencyenterprise/neurotechdevkit/actions/runs/6433204242/job/17469780145#step:4:205 (root-caused to the issue outlined in https://github.com/trustimaging/stride/pull/57)

An alternative would be to point users to install our fork of stride: https://github.com/agencyenterprise/stride