agencyenterprise / neurotechdevkit

Neurotech Development Kit (NDK)
https://agencyenterprise.github.io/neurotechdevkit/
Apache License 2.0
115 stars 10 forks source link

Update pyrevolve to 2.2.3 #150

Closed charlesbmi closed 1 year ago

charlesbmi commented 1 year ago

Issue link: https://github.com/agencyenterprise/neurotechdevkit/issues/149

Introduction

pyrevolve is a dependency of devito (the solver for the stride backend).

devito 4.7.1 Finite Difference DSL for symbolic computation.
└── pyrevolve >=2.1.3
    └── contexttimer *

The currently poetry.lock specified version of pyrevolve==2.2.2 is broken for Python 3.11 due to a Cython versioning error. This is fixed in pyrevolve==2.2.3, as noted in https://github.com/devitocodes/pyrevolve/releases/tag/v2.2.3

Changes

Temporarily specify pyrevolve==2.2.3, run poetry lock --no-update, then un-specify pyrevolve==2.2.3 (in case we want the up-to-date version in the future).

Behavior

Should be able to install neurotechdevkit using Python 3.11 on macOS and Ubuntu.

To test:

This is also tested by our CI tests.

charlesbmi commented 1 year ago

Note: I was wondering why this error wasn't caught by the CI test, and it looks like the macos-latest, 3.11 test is somehow installing the 3.10 version of pyrevolve from the cache, so it doesn't run into this error: https://github.com/agencyenterprise/neurotechdevkit/actions/runs/5978164639/job/16220900420?pr=144 (If you search for pyrevolve in the logs, you'll see that it is annotated as 3.10)

codecov-commenter commented 1 year ago

Codecov Report

Patch has no changes to coverable lines.

:loudspeaker: Thoughts on this report? Let us know!.

d-lucena commented 1 year ago

Looks like CI is running into that issue now, thanks for fixing it @charlesincharge !