Pin stride version in all the places we specify pip install

charlesbmi commented 11 months ago

https://github.com/agencyenterprise/neurotechdevkit/issues/142

Introduction

NDK uses the stride simulation software, and we instruct users to pip install from Github, picking up the latest development version. stride currently has a bug or 2 causing some NDK tests to fail (and potentially breaking for any new NDK users).

Changes

Pin stride to a known-good commit SHA. Categorized as "known-good" simply as having passed the automated tests: https://github.com/agencyenterprise/neurotechdevkit/pull/152

In the future:

It would be useful to find a way to pull this into poetry so it is one less thing to track.
We may need to update stride to do releases for this to work.

Behavior

Automated tests should pass
All pip install stride commands should have respective commit hashes

FYI @conditg

codecov-commenter commented 11 months ago

Codecov Report

All modified lines are covered by tests :white_check_mark:

:loudspeaker: Thoughts on this report? Let us know!.

charlesbmi commented 11 months ago

Thanks @stmartin and @d-lucena !

agencyenterprise / neurotechdevkit