improve perf 3-5x by avoiding re-instantiating date formatter - Githubissues

agencyenterprise / react-native-health

A React Native package to interact with Apple HealthKit

MIT License

799 stars 226 forks source link

improve perf 3-5x by avoiding re-instantiating date formatter #356

Open pelhage opened 6 months ago

pelhage commented 6 months ago

Description

Querying workouts was taking an unexpectedly long time, so did a perf trace, saw that this code was the culprit:

Modified the code and re-ran my project and saw huge savings.

TBH not sure if this needs more extensive testing (are there unit tests?), but feedback is welcome.

BEFORE:

AFTER:

Fixes # (issue)

Type of change

Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] I have made corresponding changes to the documentation
[x] I have checked my code and corrected any misspellings