search

agencyenterprise / react-native-health

A React Native package to interact with Apple HealthKit
MIT License
876 stars 235 forks source link

Support for Expo 51 SDK #383

Open seanblonien opened 2 months ago

seanblonien commented 2 months ago

Describe the bug The expo doctor command throws an error that react-native-health does not support the most up to date version of the @expo/config-plugins package necessary for Expo 51 SDK compatibility.

To Reproduce Steps to reproduce the behavior:

  1. Run the npx create-expo-app@latest command for a new Expo 51 project
  2. Run cd my-app
  3. Run npx expo install react-native-health
  4. Run npx expo-doctor
  5. See errors

Expected behavior There be no package compatibility errors when trying to use Expo 51.

Screenshots image

Smartphone (please complete the following information):

N/A

Additional context Surprised to see no one else has created an issue for this yet since Expo 51 has been out. But yea, this prevents older Expo versions from upgrading if using this package.

garygcchiu commented 2 months ago

There's a month-old PR that should address this, just need the repo maintainers to take a look 🙏 https://github.com/agencyenterprise/react-native-health/pull/381

arzola commented 2 months ago

how can we contribute to get this done?

lsandini commented 2 months ago

I see the same thing in my project. It builds fine though and step count retrieval works correctly as well.

araadt commented 3 days ago

SDK 51 is old news; SDK 52 beta is out and will be released in approx two weeks. How do we get #381 merged?

 $ npx expo-doctor@latest
✔ Check Expo config for common issues
✔ Check package.json for common issues
[…]
✖ Check that native modules use compatible support package versions for installed Expo SDK
✔ Check that packages match versions required by installed Expo SDK

Detailed check results:

Expected package @expo/config-plugins@~8.0.0
Found invalid:
  @expo/config-plugins@7.9.2
  (for more info, run: npm why @expo/config-plugins)
Advice: Upgrade dependencies that are using the invalid package versions.

One or more checks failed, indicating possible issues with the project.

And…

$ npm why @expo/config-plugins
[…]
@expo/config-plugins@7.9.2
node_modules/react-native-health/node_modules/@expo/config-plugins
  @expo/config-plugins@"^7.2.2" from react-native-health@1.19.0
  node_modules/react-native-health
    react-native-health@"^1.19.0" from the root project.