search

agenda / human-interval

Human readable time distances for javascript
Other
461 stars 14 forks source link

switch to ava #15

Closed OmgImAlexis closed 7 years ago

OmgImAlexis commented 7 years ago

This will allow us to maintain this easier as it reduces the test file's length by about 2/3 and uses ava like the other projects in agenda's org.

simison commented 7 years ago

Awesome!

LGTM :thumbsup:

I just added Travis config to master so that we can run tests in Travis as well.

~https://travis-ci.org/agenda (I don't have access to add this there, ping @joeframbach @niftylettuce)~ Edit: actually I do have rights, I was just confused by Travis interface. I'll add this there.

simison commented 7 years ago

Next up we could add a ton more tests to cover all the situations we think this package should cover (although it'll probably fail on some).

OmgImAlexis commented 7 years ago

Did you mean to close this?

simison commented 7 years ago

Nah, my bad! wrote at slack more.

-- www.mikaelkorpela.fi

On 29 Oct 2017, at 03:07, Alexis Tyler notifications@github.com wrote:

Did you mean to close this?

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/agenda/human-interval/pull/15#issuecomment-340228262, or mute the thread https://github.com/notifications/unsubscribe-auth/AAFUgO_aBfvxoAgKcHVXVAso6oCicG_Pks5sw8HBgaJpZM4QIaTW.