search

agenda / human-interval

Human readable time distances for javascript
Other
461 stars 14 forks source link

Refactor module to use node-numbered instead #19

Closed faridnsh closed 4 years ago

faridnsh commented 7 years ago

Note that this removes the languageMap support because it doesn't make sense and a quick search on Github didn't show anybody using it in an open source package. You can just release a semver major version.

However if you don't agree with this, we could easily add it back and emulate it.

Another to note that node-numbered only supports English numbers. I was thinking to support this people could provide their own English number parser(something that does exactly what numbered.parse does as an argument. We could try to extend node-numbered but I'm sure it'll never be good enough to support all languages with the same amount of code, so letting people having their own parser specific for their language makes the package more usable.

Closes #9

faridnsh commented 5 years ago

Sorry for the long response. I have rebased the PR, so the tests now pass.

simison commented 4 years ago

Follow up at https://github.com/agenda/human-interval/pull/33 and https://github.com/agenda/human-interval/pull/37