search

agens-no / AGGeometryKit

Quadrilaterals on CALayer, CGGeometry-functions, UIView/CALayer properties and other invaluable tools.
Other
1.27k stars 130 forks source link

README sample / example animation code probably needs updating #11

Closed mgrider closed 10 years ago

mgrider commented 10 years ago

You basically can't just copy/paste the README sample code. Took me looking at this for a minute to see the difference, but in the readme the animateFromPresentedStateToQuadrilateral:... method signature uses interpolationFunction:, but in the actual method, it's easeFunction:.

Also, and this is only tangentially related: (Note that I don't use cocoapods, so I don't know what happens if you use that, but...) I basically just drug the AGGeometryKit folder into my project, and that was a sub-par experience for a couple of reasons:

1) It added all the tests to my project, which require SenTestingKit 2) It didn't include those handy easing functions in easing.h & .c

Not sure if you want to do anything about those issues, they were easy to fix, just mentioning 'em.

hfossli commented 10 years ago

I get you. I will fix those issues. The recommended way is to use pods. I very much recommend to look into pods and how to use them. Once you get it - it's just so simple and fast. Very fast to try out other pods in your project.

hfossli commented 10 years ago

But I will fix it for those who does not use pods as well. :)

mgrider commented 10 years ago

The only "real" bug is the README code.

hfossli commented 10 years ago

Fixed :)