search

agens-no / AGGeometryKit

Quadrilaterals on CALayer, CGGeometry-functions, UIView/CALayer properties and other invaluable tools.
Other
1.27k stars 130 forks source link

Clean up project structure #38

Closed jflinter closed 8 years ago

jflinter commented 8 years ago

Apologies for the massive-looking PR - it's mostly file moves.

This is an incredibly useful library, but has a couple of flaws from a code-organization perspective:

This PR attempts to move things around in a way that's a little more agnostic around build tools. There's now just an .xcodeproj at the project root that just builds AGGeometryKit as a framework (notably, doing so will add support for Carthage).

I also removed the dependency on Expecta as part of this cleanup, as it wasn't really necessary (it was only being used for a few assertions in CGGeometry+AGGeometryKitTest and was simple to replace with XCTAssertEqualObjectsWithAccuracy). As such, you can now clone this repository and run the tests without having to install anything!

I recognize this is a large and difficult-to-review change, but I'm happy to answer any questions you may have.

hfossli commented 8 years ago

Hello @jflinter ! Thanks for the compliments. I really appreciate that. I think restructure looks fine as it is mostly files moved around.

The only thing I couldn't get working was the xcode playgrounds thing. I don't know what's causing it if it is the updated xcode or if it is this restructuring. I removed it as things are changing way too often to maintain IMO.