search

agens-no / AGGeometryKit

Quadrilaterals on CALayer, CGGeometry-functions, UIView/CALayer properties and other invaluable tools.
Other
1.27k stars 130 forks source link

Modify quad corners functions #49

Closed artembartle closed 7 years ago

artembartle commented 7 years ago

I've added functions that modify quad corners points. It can be useful in some cases, e.g.

AGKCorner corner;

if (controlPointView == self.topLeftControl) {
    corner = AGKCornerTopLeft;
} else if (controlPointView == self.topRightControl) {
    corner = AGKCornerTopRight;
} else if (controlPointView == self.bottomRightControl) {
    corner = AGKCornerBottomRight;
} else if (controlPointView == self.bottomLeftControl) {
    corner = AGKCornerBottomLeft;
}

quad = AGKQuadSetPointForCorner(quad, corner, panLocation);
artembartle commented 7 years ago

Yep, I agree. "Modify" is explaining the result much better

artembartle commented 7 years ago

I pushed changes to my fork repository master branch. But I don't see them here. Does travis kinda throttle checks for some time? Or should I close this PR and create a new one?

hfossli commented 7 years ago

That’s superweird!!! I have no idea what’s going on

hfossli commented 7 years ago

Don’t close it, yet :) I want to find out what’s going on

artembartle commented 7 years ago

Sure, take your time

hfossli commented 7 years ago

I have contacted github support. Waiting for their reply :)

hfossli commented 7 years ago

From github staff

Hey Håvard,

Thanks for getting in touch! I agree, that is really strange. :)

It looks like there was some kind of glitch that caused your pull request to not show the latest commits on that branch. I was able to synchronize that pull request on our end, so it should be updated now.

This likely was just a one-time glitch, but if you run into this again, please let us know!

Cheers

artembartle commented 7 years ago

Cheers!

hfossli commented 7 years ago

Thanks a lot! Merged and released on cocoapods as 1.2.7!