search

agens-no / EllipticCurveKeyPair

Sign, verify, encrypt and decrypt using the Secure Enclave
Other
709 stars 115 forks source link

Fix operationPrompt config parameter #17

Closed alkalim closed 6 years ago

alkalim commented 6 years ago

Fix for previously unused property EllipticCurveKeyPair.Config.operationPrompt

hfossli commented 6 years ago

Hello! Thanks for submitting this pull request. I really appreciate it. ❤️ Much love.

Please note that the operationPrompt property might be removed in a future release. It might be that I find it better to provide a custom localized text by configuring a LAContext object from the outside. I haven't settled quite on that yet.

alkalim commented 6 years ago

Hi, you're welcome and thanks for the great and very useful library! :)

Why not to provide both operationPrompt and LAContext? Former for those who just need a drop in EC support without diving into LA framework and latter for a fine-grained control?

Also it would be nice to give users the option to change operationPrompt on the fly without recreating the manager every time - this is what I ended up doing after realizing the config property is private.