search

agens-no / EllipticCurveKeyPair

Sign, verify, encrypt and decrypt using the Secure Enclave
Other
708 stars 114 forks source link

Public initializer for EllipticCurveKeyPair.Helper #40

Closed keefertaylor closed 5 years ago

keefertaylor commented 5 years ago

The default initializers for public structs in Swift is internal [1] which prevents EllipticCurveKeyPair.Helper from being instantiated. This reduces flexibility in the design because the only way to use EllipticCurveKeyPair.Helper is through the opinionated EllipticCurveKeyPair.Manager class.

Class documentation for both Manager and Helper seem to suggest that wrapping Helper in a facade is intended functionality, which is currently not available.

[1] https://docs.swift.org/swift-book/LanguageGuide/AccessControl.html#ID19

hfossli commented 5 years ago

Thank you! 💯💯💯

keefertaylor commented 5 years ago

How would you feel about cutting a new release so I can access this functionality through cocoa pods?

hfossli commented 5 years ago

Sure! I can publish asap :)

tommyle commented 4 years ago

Sure! I can publish asap :)

Any ETA on this?