search

agens-no / EllipticCurveKeyPair

Sign, verify, encrypt and decrypt using the Secure Enclave
Other
708 stars 114 forks source link

- swift 5 compatibility #41

Closed laszlo-major closed 5 years ago

laszlo-major commented 5 years ago

Just a small change since the deallocate/deinit methods were changed/deprecated in swift 4.1 and completely removed in 5.0. As per https://github.com/apple/swift-evolution/blob/master/proposals/0184-unsafe-pointers-add-missing.md

This change preserves the same behaviour, with the new API.

hfossli commented 5 years ago

Wowza, thanks! Should we maybe have if swift version 5 and 4 added? Don't want to break things for swift 4 folks :)

laszlo-major commented 5 years ago

This change should be compatible from 4.1 and up, which is a fine range to support in my opinion, but maybe it should be mentioned in the readme? Would you like me to add that?

hfossli commented 5 years ago

Thanks a lot!