agent-kilo / jwno

A tiling window manager for Windows 10/11, built with Janet and ❤️. This repo is a one-way mirror. The actual development happens in a separate Fossil repo.
https://agent-kilo.github.io/jwno/
MIT License
17 stars 1 forks source link

Windows position and size, with taskbar in Win11 #3

Open pepe opened 1 day ago

pepe commented 1 day ago

Hello. I found this program a great companion. Using Janet, I made my Win11 more ergonomic than my hand-crafted River on Wayland setup on Linux.

One thing with which I need help, though, is the size of the windows. They do not take the Windows Taskbar into account, and the bottom of the window is obscured. It is not always, and I still need to understand the pattern.

I would like to ask you for guidance in debugging so that I can understand and fix the behavior.

agent-kilo commented 1 day ago

They do not take the Windows Taskbar into account, and the bottom of the window is obscured.

Did this always happen to specific windows? All I can think of right now is that maybe those windows have minimum size limits, and they "overflowed" from the frames at the bottom. Can you take a screenshot when this happens, and see if those windows are of their minimum sizes? If that's the case, the :frame-to-window-size command may be able to fix it.

Windows (the OS) calls the desktop space excluding the taskbar "work areas", Jwno should have accounted for the taskbar here and in this function.

That said, I run Windows 10 on my machine, and Jwno is only tested in Win 11 VMs. Since Microsoft recently removed download links to their free VM images, I didn't really test Jwno on Win 11 lately. Maybe it's a Win 11 thing. I'll try to get a Win 11 setup ASAP.

pepe commented 1 day ago

Thank you very much! I am happy to test Win11 every day. After writing about this issue, I set the taskbar to hide, and the problem did not manifest. But after setting it to always show, the problem is back. Please see the screenshot of the Zulip client. image

pepe commented 1 day ago

One more thing. Please, no hurry; with the taskbar hiding, I am fine.

agent-kilo commented 1 day ago

... I set the taskbar to hide, and the problem did not manifest. But after setting it to always show, the problem is back.

I see. When the space reserved by the taskbar is changed, Windows (the OS) would send some message to Jwno IIRC, but Jwno doesn't handle it currently 😅.

In this case, can you try Update Monitor Layout from Jwno's notification icon menu, and see if the work area can be resized properly, thus fixing the problem?

Capture

I wonder if this is the same problem you described in the original issue though.

They do not take the Windows Taskbar into account, and the bottom of the window is obscured.

Does this still happen when you're not changing the taskbar settings at all?

pepe commented 8 hours ago

Update Monitor Layout command fixes it.

It happened before I started to do anything with the taskbar settings.

I will investigate more later. Thank you.

agent-kilo commented 7 hours ago

Great, thank you for the feedback!

You can start Jwno like this, to have its logs written to a file:

jwno.exe --log-level debug --log-file <file name> --no-console

So that we may be able to do a postmortem if it happened again.

And I should indeed test it more on Win 11. I just found a bug when playing with Win 11's Paint app, but that's another story 😅