fix (Bug 1002:createMongoDbLikeId): microsecond float to big integer …

agentejo / cockpit

Add content management functionality to any site - plug & play / headless / api-first CMS

http://getcockpit.com

MIT License

5.4k stars 524 forks source link

fix (Bug 1002:createMongoDbLikeId): microsecond float to big integer … #1465

Closed abernh closed 3 years ago

abernh commented 3 years ago

…before binary conversion

microseconds were omitted when using pack with format 'N', causing timestamp to be reduced to "seconds", causing high chances of equal IDs on import processes

Rel: Issue #1002

abernh commented 3 years ago

I tested the "old" and "fixed" createMongoDbLikeId() method by running it in a while loop

"old": created duplicates within just a few thousand iterations,
"fixed": "never" created a duplicate (stopped script after ~40sec runtime)

(my machine: Ubuntu 20, Apache, PHP7.4, Core i7-8550U, 12GB Ram)

aheinze commented 3 years ago

Thanks 👍