UX Suggestion: Dismiss confirmation modal with ESC

agentejo / cockpit

Add content management functionality to any site - plug & play / headless / api-first CMS

http://getcockpit.com

MIT License

5.4k stars 524 forks source link

UX Suggestion: Dismiss confirmation modal with ESC #1501

Closed mountainash closed 2 years ago

mountainash commented 2 years ago

When flicking between the different top level menus, the exploration flow is stopped on the "Deploy" section with the forced mouse only interaction with the "Do you want to re-deploy the Website" modal.

Suggestions

[x] allow the "cancel" flow to be actioned by pressing the esc key
[x] allow tab key presses to focus the front-most buttons (currently it tabs through the greyed out content

aheinze commented 2 years ago

Hey 👋 You're referring to Cockpit v2 - Please create your issue / suggestion here: https://github.com/Cockpit-HQ/Cockpit

Thanks!

aheinze commented 2 years ago

Btw, now fixed here https://github.com/Cockpit-HQ/Cockpit/commit/48ff14341ef7e8018cc153727e37580bb1e8ebf8

mountainash commented 2 years ago

Awesome @aheinze ... Can I suggest adding a CONTRIBUTING file to this repo to suggest issues are created on the new repo?

It might save you some comment repition?