search

agentejo / mongo-lite

Schemaless database on top of SQLite
160 stars 19 forks source link

use php 5.3 array notation: array() instead of [] #7

Closed gicque closed 9 years ago

gicque commented 9 years ago

ensuring compatibility with php 5.3

nunocodex commented 9 years ago

Bad idea for me, php 5.3 it's really old now, and EOL for 5.5 nearly so no sense to change the array annotation, the best way is update composer.json and put new php version inside.

gicque commented 9 years ago

since MongoLite do not use any new fonctionality not supported by PHP 5.3 except for the new array notation, i don't see why it would be a bad idea, more people would be able to use it without costing anything for the others.

nunocodex commented 9 years ago

@gicque all cheap hosting have php 5.4. One my client have a very cheap hosting (6 dollars / year) and have php 5.6 :)

gicque commented 9 years ago

@namaless absolutely, but there are some people who can't use anything but PHP 5.3, and my PR doesn't do anything against PHP 5.4+ it just makes sure that users of PHP5.3+ can use this package :)

aheinze commented 9 years ago

thank you for the contribution, but php 5.3 is dead. I don't want to have legacy code in the codebase just because of php 5.3 support.