ast grep, filtering

[maks-ivanov]

Description

• Refactored the file watching mechanism in WorkspaceDocumentsHandler to use an external receiver, removing the internal debouncer.
• Added constants for exclude patterns and root files for Python, TypeScript, and Rust.
• Simplified SymbolResponse type and updated Symbol struct to include identifier_position and range.
• Replaced LSP-based symbol retrieval with AST grep in definitions_in_file handler.
• Updated and added tests to accommodate changes in file watching and symbol retrieval.

---

Changes walkthrough

Relevant files

Enhancement

workspace_documents.rs Refactor file watching and add language-specific constants          lsproxy/src/utils/workspace_documents.rs Removed internal debouncer and used external receiver for file watching. Added constants for exclude patterns and root files for Python, TypeScript, and Rust. Updated tests to reflect changes in file watching mechanism. Refactored file watching logic to use broadcast channels. +68/-52  api_types.rs Simplify SymbolResponse and update Symbol struct                              lsproxy/src/api_types.rs Simplified SymbolResponse type to a vector of Symbol. Updated Symbol struct to include identifier_position and range. Adjusted related request structures. +13/-197 definitions_in_file.rs Replace LSP-based symbol retrieval with AST grep                              lsproxy/src/handlers/definitions_in_file.rs Replaced LSP-based symbol retrieval with AST grep in definitions_in_file handler. Simplified error handling and response structure. Updated tests to reflect changes in symbol retrieval. +73/-131

💡 Usage Guide

### Checking Your Pull Request Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later. ### Talking to CodeAnt AI Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:

@codeant-ai ask: Your question here

This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code. ### Retrigger review Ask CodeAnt AI to review the PR again, by typing:

@codeant-ai: review

### Check Your Repository Health To analyze the health of your code repository, visit our dashboard at [app.codeant.ai](https://app.codeant.ai). This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.

[codeant-ai[bot]]

Things to consider 🐛

• In the WorkspaceDocumentsHandler::new function, the watch_events_rx receiver is cloned and made mutable, but there is no handling for the case where the receiver might be closed or disconnected. This could lead to the loop in line 77 running indefinitely or causing a panic if the sender is dropped.

• In the fetch_definition_source_code function, the match statement on line 115 assumes that the manager.definitions_in_file call will always return a DocumentSymbolResponse::Nested. If it returns a DocumentSymbolResponse::Flat, the function will return an error, which might not be the intended behavior. This could lead to unexpected failures when processing certain files.

• The extract_range function in WorkspaceDocumentsHandler does not handle cases where the provided range exceeds the bounds of the content. This could lead to panics or incorrect results if the range is out of bounds, especially when the range specifies lines or characters that do not exist in the content.