agentic-labs / lsproxy

Multi-language code navigation API in a container
https://lsproxy.dev
GNU Affero General Public License v3.0
43 stars 3 forks source link

Handle empty definitions #68

Closed robmck1995 closed 1 week ago

robmck1995 commented 1 week ago

Description


Changes walkthrough

Relevant files
Bug fix
client.rs
Handle null result in goto definition response                                 

lsproxy/src/lsp/client.rs
  • Added handling for null result by defaulting to an empty array.
  • Prevented deserialization failure when result is null.
  • +7/-1     
    💡 Usage Guide ### Checking Your Pull Request Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later. ### Talking to CodeAnt AI Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:
    @codeant-ai ask: Your question here
    
    This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code. ### Retrigger review Ask CodeAnt AI to review the PR again, by typing:
    @codeant-ai: review
    
    ### Check Your Repository Health To analyze the health of your code repository, visit our dashboard at [app.codeant.ai](https://app.codeant.ai). This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.
    codeant-ai[bot] commented 1 week ago

    Things to consider 🐛