Invalid shapes of newly created elements

agentlab / ldkg-ui-diags

Web-based diagram editor

GNU General Public License v3.0

2 stars 3 forks source link

Invalid shapes of newly created elements #4

Open Shamann opened 3 years ago

Shamann commented 3 years ago

A shape of newly created elements is not modified upon shape switching. Reproduced on https://github.com/agentlab/rdf4j-workspace/commit/d5385ecd6ce3445f275b1a98c73c3b1e96191585

InvalidShapes

Mvwivs commented 3 years ago

Currently elements created from Stencil are only added to x6 graph. To allow layout calculations/view swithing elements should be added to application state (in this case sh:Shape and sh:Property collection), then state updates are propogated to Canvas, nodes and so on. Adding nodes to state requires API from Mobx State Tree (@agentlab/sparql-jsld-client), this in turn requires "View" / "View kind" separation implementation #1