Move hardcoded node and line stencils into configs - Githubissues

agentlab / ldkg-ui-diags

Web-based diagram editor

GNU General Public License v3.0

2 stars 3 forks source link

Move hardcoded node and line stencils into configs #67

Closed amivanoff closed 3 years ago

amivanoff commented 3 years ago

Some hardcoded stencils in different places:
- graphCore.tsx
- Stencil.tsx
- yoga.ts, kiwi.ts
- interactionValidation.ts

Stencils, which should be in test configs in ViewKind/ViewDescr or storybooks only:

rm:GeneralCompartmentNodeStencil
rm:PropertiesCompartmentNodeStencil
rm:PropertyNodeStencil
rm:ClassNodeStencil
rm:WindTurbineStencil
rm:HeaterStencil
rm:HouseStencil
rm:SubstationStencil
rm:GeneratorStencil

For arrow types we need stensils-like mechanics with protoStencil = 'rm:EdgeStencil'. Arrow stencil palette should also use registered arrow types. We should remove hardcoded custom 'lines' and move it into test configs in ViewKind/ViewDescr or storybooks only:
- rm:AssociationArrowStencil
- rm:InheritanceArrowStencil
- rm:Line
- rm:DoubleLine