agentlab / ldkg-ui-diags

Web-based diagram editor
GNU General Public License v3.0
2 stars 3 forks source link

GH-75 [FIX] fixed stencil panel and panning #77

Closed amivanoff closed 3 years ago

amivanoff commented 3 years ago

Closes #75

sonarcloud[bot] commented 3 years ago

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 6 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

amivanoff commented 3 years ago

Could you please fix this setter (setMaxWidth/setMaxHeight) errors which we have for a while in tests:

 console.log                                                                                                                                                                                                                                                                                                                                                                       
    Error: Invalid value none for setMaxWidth
        at Bound.<anonymous> (C:\SES\ldkg-ui-diags\node_modules\yoga-layout-prebuilt\yoga-layout\dist\entry-common.js:167:17)
        at Bound.prototype.<computed> [as setMaxWidth] (C:\SES\ldkg-ui-diags\node_modules\yoga-layout-prebuilt\yoga-layout\dist\entry-common.js:133:22)
        at C:\SES\ldkg-ui-diags\src\components\diagram\layout\yoga.ts:190:57
        at Array.forEach (<anonymous>)
        at applyProperties (C:\SES\ldkg-ui-diags\src\components\diagram\layout\yoga.ts:187:5)
        at addNode (C:\SES\ldkg-ui-diags\src\components\diagram\layout\yoga.ts:338:3)
        at Object.handleGraphEvent (C:\SES\ldkg-ui-diags\src\components\diagram\layout\yoga.ts:216:5)
        at Object.<anonymous> (C:\SES\ldkg-ui-diags\test\yoga.test.tsx:7:21)
        at Promise.then.completed (C:\SES\ldkg-ui-diags\node_modules\jest-circus\build\utils.js:390:28)
        at new Promise (<anonymous>)
        at callAsyncCircusFn (C:\SES\ldkg-ui-diags\node_modules\jest-circus\build\utils.js:315:10)
        at _callCircusTest (C:\SES\ldkg-ui-diags\node_modules\jest-circus\build\run.js:218:40)
        at processTicksAndRejections (node:internal/process/task_queues:96:5)
        at _runTest (C:\SES\ldkg-ui-diags\node_modules\jest-circus\build\run.js:155:3)
        at _runTestsForDescribeBlock (C:\SES\ldkg-ui-diags\node_modules\jest-circus\build\run.js:66:9)
        at _runTestsForDescribeBlock (C:\SES\ldkg-ui-diags\node_modules\jest-circus\build\run.js:60:9)
        at run (C:\SES\ldkg-ui-diags\node_modules\jest-circus\build\run.js:25:3)
        at runAndTransformResultsToJestFormat (C:\SES\ldkg-ui-diags\node_modules\jest-circus\build\legacy-code-todo-rewrite\jestAdapterInit.js:166:21)
        at jestAdapter (C:\SES\ldkg-ui-diags\node_modules\jest-circus\build\legacy-code-todo-rewrite\jestAdapter.js:82:19)
        at runTestInternal (C:\SES\ldkg-ui-diags\node_modules\jest-runner\build\runTest.js:389:16)
        at runTest (C:\SES\ldkg-ui-diags\node_modules\jest-runner\build\runTest.js:481:34)
        at Object.worker (C:\SES\ldkg-ui-diags\node_modules\jest-runner\build\testWorker.js:133:12)

      at src/components/diagram/layout/yoga.ts:192:15
          at Array.forEach (<anonymous>)

  console.log
    Error: Invalid value none for setMaxHeight
        at Bound.<anonymous> (C:\SES\ldkg-ui-diags\node_modules\yoga-layout-prebuilt\yoga-layout\dist\entry-common.js:167:17)
        at Bound.prototype.<computed> [as setMaxHeight] (C:\SES\ldkg-ui-diags\node_modules\yoga-layout-prebuilt\yoga-layout\dist\entry-common.js:133:22)
        at C:\SES\ldkg-ui-diags\src\components\diagram\layout\yoga.ts:190:57
        at Array.forEach (<anonymous>)
        at applyProperties (C:\SES\ldkg-ui-diags\src\components\diagram\layout\yoga.ts:187:5)
        at addNode (C:\SES\ldkg-ui-diags\src\components\diagram\layout\yoga.ts:338:3)
        at Object.handleGraphEvent (C:\SES\ldkg-ui-diags\src\components\diagram\layout\yoga.ts:216:5)
        at Object.<anonymous> (C:\SES\ldkg-ui-diags\test\yoga.test.tsx:7:21)
        at Promise.then.completed (C:\SES\ldkg-ui-diags\node_modules\jest-circus\build\utils.js:390:28)
        at new Promise (<anonymous>)
        at callAsyncCircusFn (C:\SES\ldkg-ui-diags\node_modules\jest-circus\build\utils.js:315:10)
        at _callCircusTest (C:\SES\ldkg-ui-diags\node_modules\jest-circus\build\run.js:218:40)
        at processTicksAndRejections (node:internal/process/task_queues:96:5)
        at _runTest (C:\SES\ldkg-ui-diags\node_modules\jest-circus\build\run.js:155:3)
        at _runTestsForDescribeBlock (C:\SES\ldkg-ui-diags\node_modules\jest-circus\build\run.js:66:9)
        at _runTestsForDescribeBlock (C:\SES\ldkg-ui-diags\node_modules\jest-circus\build\run.js:60:9)
        at run (C:\SES\ldkg-ui-diags\node_modules\jest-circus\build\run.js:25:3)
        at runAndTransformResultsToJestFormat (C:\SES\ldkg-ui-diags\node_modules\jest-circus\build\legacy-code-todo-rewrite\jestAdapterInit.js:166:21)
        at jestAdapter (C:\SES\ldkg-ui-diags\node_modules\jest-circus\build\legacy-code-todo-rewrite\jestAdapter.js:82:19)
        at runTestInternal (C:\SES\ldkg-ui-diags\node_modules\jest-runner\build\runTest.js:389:16)
        at runTest (C:\SES\ldkg-ui-diags\node_modules\jest-runner\build\runTest.js:481:34)
        at Object.worker (C:\SES\ldkg-ui-diags\node_modules\jest-runner\build\testWorker.js:133:12)

      at src/components/diagram/layout/yoga.ts:192:15
          at Array.forEach (<anonymous>)