search

agentm / project-m36

Project: M36 Relational Algebra Engine
The Unlicense
876 stars 47 forks source link

make tests compile for GHC < 8.6.1 #264

Closed samb96 closed 3 years ago

samb96 commented 4 years ago

I included a conditional in the cabal file of my earlier pull request that causes the tests not to compile for GHC < 8.6.1. I had realized that it's not necessary, but accidentally included it in the pull request. All features actually used in the module are available before GHC 8.6, it's just not very useful without DerivingVia which was introduced in GHC 8.6.1. Sorry about that, I should have been more careful.

agentm commented 3 years ago

I see- thanks for catching that. What about the new CustomTupleable example? Should that conditionalized on 8.6.1?

Update: Ah, I see it's commented out entirely. It would be nice to conditionalize that because the CI builders also build examples to check for bitrot.

agentm commented 3 years ago

Thanks! I cherry-picked the original fix and added a conditional around "Buildable" for the deriving custom tupleable example.