search

agentsoz / ees

Emergency Evacuation Simulator
MIT License
9 stars 6 forks source link

testCastlemaine1000 results are non-deterministic #15

Closed dhixsingh closed 6 years ago

dhixsingh commented 6 years ago

From @dhixsingh on March 6, 2018 3:17

Picking up from where #8 left. The results for the congestion test testCastlemaine1000 are non-deterministic.

The differences are in the number and timing of : 1) activity starts; 1) persons arriving.

The comparison tests are currently disabled:

https://github.com/agentsoz/bdi-abm-integration/blob/6a015b53a7e4718eed75929d024ad8e3f9b76596/examples/bushfire/src/test/java/io/github/agentsoz/ees/Castlemaine1000Test.java#L47-L65

Copied from original issue: agentsoz/bdi-abm-integration#23

dhixsingh commented 6 years ago

From @osbornejr on March 23, 2018 7:6

Checks fail on the two Torquay tests, potentially for a similar reason (threading). May be due to other issue but it is very hard to determine when they give different output each time, so I will wait until this is resolved in any case.

dhixsingh commented 6 years ago

From @kainagel on August 10, 2018 12:54

Is this still an issue? I haven't seen nondeterminism in the test outputs now for some time, but maybe this one here is switched off?

dhixsingh commented 6 years ago

The latest test in question is here: https://github.com/agentsoz/ees/blob/3207fdb7675dc0957d411faf8cfa78458e025a9b/src/test/java/io/github/agentsoz/ees/Castlemaine1000Test.java

Am closing this as I have not seen any issues for a while now. Also the recent overhaul of the BDI-ABM interaction (agentsoz/bdi-abm-integration#12) has meant that a lot of threading issues are resolved.