agenttux / dolphin-extract-here-and-delete

Service Menu for KDE Dolphin file manager that adds a Extract Here and Delete command to the top level context menu. This command uses the Ark utility to extract an archive in the current directory and then deletes the archive file it just extracted from.
GNU General Public License v3.0
2 stars 2 forks source link

zip gets deleted even if ark extraction fails #2

Open drone1 opened 1 year ago

drone1 commented 1 year ago

Apologies but I think this isn't your bug, however https://github.com/KDE/ark has no Issues tab that I can see and I want to report it somewhere for anyone who cares:

I see you're using && in your command (rk -ba %u && rm %u currently) but I guess ark isn't returning an error exit code on failure, because I get an error that I'm out of disk space (even after I cleared disk space and have more than enough available now to extract a 5MB zip).

Not sure if there is anything you can do on your end since ark doesn't appear to have any workaround for this that I can see. Thanks.

agenttux commented 3 months ago

I can maybe look into only running the delete if the extract succeeds. Thanks for pointing out the issue.

drone1 commented 3 months ago

That would be greatly appreciated. Thank you.

On Tue 21. May 2024 at 11:29, agenttux @.***> wrote:

I can maybe look into only running the delete if the extract succeeds. Thanks for pointing out the issue.

— Reply to this email directly, view it on GitHub https://github.com/agenttux/dolphin-extract-here-and-delete/issues/2#issuecomment-2121655797, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABQIEPG7LM5W3CBF72FQ5ITZDK5SFAVCNFSM6AAAAAAQ7XAVI2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMRRGY2TKNZZG4 . You are receiving this because you authored the thread.Message ID: @.***>