search

agera-edc / DataSpaceConnector

DataspaceConnector project
Apache License 2.0
1 stars 0 forks source link

Automated Tests for Sample 04.3 #198

Open ouphi opened 2 years ago

ouphi commented 2 years ago

Feature #194 upstream: https://github.com/eclipse-dataspaceconnector/DataSpaceConnector/issues/1045 After #252

Description

Automated integration tests that run in CI should be added for samples to prevent the samples breaking due to changes in the EDC. The scope of this story is to add automated integration tests for sample 04.3.

Sample 04.3 is based on a docker-compose + commands specified in the readme. Having tests running the docker-compose + the commands to make sure that the sample is not broken would help avoiding breaking it.

The existing client-side integration test can be used: FileTransferAsClientIntegrationTest

Note: it was decided that EDC integration tests should not rely on samples. However, it is desirable to have additional tests to make sure that the samples don't get broken.

Acceptance criteria

Tasks

zeier commented 2 years ago

Decision required whether we have tests for samples in the first place. Issue currently is that samples break all the time.

zeier commented 2 years ago

Backlog refinement: Samples 4.0 to 4.3 should have automated tests to prevent that these samples get broken.

pkirch commented 2 years ago

Feature branch: https://github.com/agera-edc/DataSpaceConnector/tree/feature/1045-automated-tests-sample-4-3 Sub-feature branch: https://github.com/agera-edc/DataSpaceConnector/tree/feature/1045/198-automated-tests-sample-4-3

zeier commented 2 years ago

Put on hold, as it is projected to be too much scope for the team until end of August.

36 and #157 have higher priority.

This item can be taken up again if there is capacity.