agera-edc / DataSpaceConnector

DataspaceConnector project
Apache License 2.0
1 stars 0 forks source link

FsVault: Add Parsers implementation in FsPrivateKeyResolver to support PrivateKeyResolver for PrivateKeyWrapper #322

Closed cpeeyush closed 2 years ago

cpeeyush commented 2 years ago

What this PR changes/adds

Why it does that

This change helps in resolving private keys in different formats when using File System Vault by providing appropriate parsers. For instance, in MVD when we use FileSystemVault for testing purpose there IdentityDidCoreExtension generates an exception as FsPrivateKeyResolver.resolvePrivateKey is not able to parse a ECKey from keystore to PrivateKeyWrapper.class

Linked Issue(s)

Relates to https://github.com/agera-edc/MinimumViableDataspace/issues/56

Checklist

codecov-commenter commented 2 years ago

Codecov Report

Merging #322 (bb026ee) into feature/1658/add-parsers-fs-vault (2223347) will decrease coverage by 0.01%. The diff coverage is 76.47%.

@@                          Coverage Diff                          @@
##           feature/1658/add-parsers-fs-vault     #322      +/-   ##
=====================================================================
- Coverage                              67.31%   67.30%   -0.02%     
=====================================================================
  Files                                    771      772       +1     
  Lines                                  16599    16615      +16     
  Branches                                1050     1051       +1     
=====================================================================
+ Hits                                   11173    11182       +9     
- Misses                                  4945     4951       +6     
- Partials                                 481      482       +1     
Impacted Files Coverage Δ
...onnector/spi/security/VaultPrivateKeyResolver.java 66.66% <0.00%> (-15.16%) :arrow_down:
...nnector/core/security/fs/FsPrivateKeyResolver.java 66.66% <76.47%> (-3.93%) :arrow_down:
...ector/spi/security/AbstractPrivateKeyResolver.java 81.25% <81.25%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2223347...bb026ee. Read the comment docs.

github-actions[bot] commented 2 years ago

Unit Test Results

     429 files  ±0       429 suites  ±0   23m 58s :stopwatch: +35s 12 469 tests +1  12 455 :heavy_check_mark: +1  14 :zzz: ±0  0 :x: ±0  12 536 runs  +1  12 522 :heavy_check_mark: +1  14 :zzz: ±0  0 :x: ±0 

Results for commit bb026ee6. ± Comparison against base commit 22233470.

:recycle: This comment has been updated with latest results.