agera-edc / MinimumViableDataspace

Guidance on documentation, scripts and integration steps on using the EDC project results
Apache License 2.0
0 stars 2 forks source link

Application Insights in Registration Service #261

Closed Izzzu closed 2 years ago

Izzzu commented 2 years ago

What this PR changes/adds

Add Application insights connection string to Registration Service deployment set up.

Screenshot of correlated traces in Registration Service visible in Application Insights after the changes:

Screenshot 2022-08-17 at 21 10 12

Why it does that

To enable collecting traces, logs and metrics in Azure Insights for Registration Service instance.

Further notes

Fix after upgrading Registration Service version: use ParticipantDto in RegistrationServiceNodeDirectory class.

Updating README to include command to build Registration Service CLI.

Please note the PR will be merged after the https://github.com/agera-edc/RegistrationService/pull/27 in Registration Service is merged upstream to update the version.

Linked Issue(s)

Linked to #247

Checklist

github-actions[bot] commented 2 years ago

Unit Test Results

27 tests   26 :heavy_check_mark:  36s :stopwatch:   7 suites    1 :zzz:   7 files      0 :x:

Results for commit 5d69f932.

:recycle: This comment has been updated with latest results.

codecov-commenter commented 2 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (feature/247-appinsights-registrservice@60d012a). Click here to learn what that means. The diff coverage is n/a.

@@                            Coverage Diff                            @@
##             feature/247-appinsights-registrservice     #261   +/-   ##
=========================================================================
  Coverage                                          ?   78.78%           
  Complexity                                        ?       20           
=========================================================================
  Files                                             ?        5           
  Lines                                             ?       66           
  Branches                                          ?        5           
=========================================================================
  Hits                                              ?       52           
  Misses                                            ?       14           
  Partials                                          ?        0           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.