agera-edc / MinimumViableDataspace

Guidance on documentation, scripts and integration steps on using the EDC project results
Apache License 2.0
0 stars 2 forks source link

Upgrade Registration Service to the latest version #262

Closed Izzzu closed 2 years ago

Izzzu commented 2 years ago

What this PR changes/adds

This PR upgrades Registration Service version to the latest upstream revision and fixes all the incompatibility issues:

Why it does that

MVD is not compatible with the latest Registration Service changes.

Linked Issue(s)

Closes #266

Checklist

github-actions[bot] commented 2 years ago

Unit Test Results

27 tests  ±0   26 :heavy_check_mark: ±0   42s :stopwatch: -1s   7 suites ±0     1 :zzz: ±0    7 files   ±0     0 :x: ±0 

Results for commit 0ed08921. ± Comparison against base commit 8e1c8802.

This pull request removes 7 and adds 7 tests. Note that renamed tests count towards both. ``` org.eclipse.dataspaceconnector.mvd.FederatedCacheNodeResolverTest ‑ [1] [org.eclipse.dataspaceconnector.iam.did.spi.document.Service@21dea711] org.eclipse.dataspaceconnector.mvd.FederatedCacheNodeResolverTest ‑ [1] org.eclipse.dataspaceconnector.spi.result.Result@5b1420f9 org.eclipse.dataspaceconnector.mvd.FederatedCacheNodeResolverTest ‑ [2] [org.eclipse.dataspaceconnector.iam.did.spi.document.Service@39004e4f, org.eclipse.dataspaceconnector.iam.did.spi.document.Service@5f0ca069] org.eclipse.dataspaceconnector.mvd.FederatedCacheNodeResolverTest ‑ [2] org.eclipse.dataspaceconnector.spi.result.Result@53b2e1eb org.eclipse.dataspaceconnector.mvd.FederatedCacheNodeResolverTest ‑ [3] [org.eclipse.dataspaceconnector.iam.did.spi.document.Service@6a6a2fdd, org.eclipse.dataspaceconnector.iam.did.spi.document.Service@552ffa44] org.eclipse.dataspaceconnector.mvd.FederatedCacheNodeResolverTest ‑ [3] org.eclipse.dataspaceconnector.spi.result.Result@29db008c org.eclipse.dataspaceconnector.mvd.FederatedCacheNodeResolverTest ‑ [4] org.eclipse.dataspaceconnector.spi.result.Result@1d008e61 ``` ``` org.eclipse.dataspaceconnector.mvd.FederatedCacheNodeResolverTest ‑ [1] [org.eclipse.dataspaceconnector.iam.did.spi.document.Service@733f1395] org.eclipse.dataspaceconnector.mvd.FederatedCacheNodeResolverTest ‑ [1] org.eclipse.dataspaceconnector.spi.result.Result@5059d398 org.eclipse.dataspaceconnector.mvd.FederatedCacheNodeResolverTest ‑ [2] [org.eclipse.dataspaceconnector.iam.did.spi.document.Service@57ed02e6, org.eclipse.dataspaceconnector.iam.did.spi.document.Service@39004e4f] org.eclipse.dataspaceconnector.mvd.FederatedCacheNodeResolverTest ‑ [2] org.eclipse.dataspaceconnector.spi.result.Result@4de93edd org.eclipse.dataspaceconnector.mvd.FederatedCacheNodeResolverTest ‑ [3] [org.eclipse.dataspaceconnector.iam.did.spi.document.Service@5f0ca069, org.eclipse.dataspaceconnector.iam.did.spi.document.Service@6a6a2fdd] org.eclipse.dataspaceconnector.mvd.FederatedCacheNodeResolverTest ‑ [3] org.eclipse.dataspaceconnector.spi.result.Result@53b2e1eb org.eclipse.dataspaceconnector.mvd.FederatedCacheNodeResolverTest ‑ [4] org.eclipse.dataspaceconnector.spi.result.Result@29db008c ```

:recycle: This comment has been updated with latest results.

codecov-commenter commented 2 years ago

Codecov Report

Merging #262 (698674d) into bug/266-update-rs-ver (0a73eff) will not change coverage. The diff coverage is n/a.

@@                   Coverage Diff                    @@
##             bug/266-update-rs-ver     #262   +/-   ##
========================================================
  Coverage                    78.78%   78.78%           
  Complexity                      20       20           
========================================================
  Files                            5        5           
  Lines                           66       66           
  Branches                         5        5           
========================================================
  Hits                            52       52           
  Misses                          14       14           
Impacted Files Coverage Δ
...spaceconnector/mvd/FederatedCacheNodeResolver.java 100.00% <ø> (ø)
...onnector/mvd/RegistrationServiceNodeDirectory.java 90.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.