cpeeyush commented 2 years ago

What this PR changes/adds

As the registration service now has an endpoint to fetch the record of a participant, this can be utilized during participant onboarding to verify that onboarding completed successfully or not.
Update to system-tests/README.md necessary for a successful build of Registration service
Add health check to system-tests/resources/cli-tools/Dockerfile to have an indicator when container cli-tools is finished.
Updated to use latest version of registration service.

Why it does that

Validate if a participant onboarded successfully or not.

Linked Issue(s)

Relates to https://github.com/agera-edc/MinimumViableDataspace/issues/46

Checklist

[ ] added appropriate tests?
[x] performed checkstyle check locally?
[ ] added/updated copyright headers?
[ ] documented public classes/methods?
[ ] added/updated relevant documentation?
[ ] added relevant details to the changelog? (skip with label no-changelog)
[x] formatted title correctly?

github-actions[bot] commented 2 years ago

Unit Test Results

  7 files ±0   7 suites ±0 42s :stopwatch: -1s 27 tests ±0 26 :heavy_check_mark: ±0 1 :zzz: ±0 0 :x: ±0 30 runs ±0 29 :heavy_check_mark: ±0 1 :zzz: ±0 0 :x: ±0

Results for commit 4cdada1b. ± Comparison against base commit adb74333.

:recycle: This comment has been updated with latest results.

codecov-commenter commented 2 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (feature/46-verify-onboarding-status@77d7f35). Click here to learn what that means. The diff coverage is n/a.

@@                          Coverage Diff                           @@
##             feature/46-verify-onboarding-status     #263   +/-   ##
======================================================================
  Coverage                                       ?   78.78%           
  Complexity                                     ?       20           
======================================================================
  Files                                          ?        5           
  Lines                                          ?       66           
  Branches                                       ?        5           
======================================================================
  Hits                                           ?       52           
  Misses                                         ?       14           
  Partials                                       ?        0

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

agera-edc / MinimumViableDataspace

Verify participant onboarding status #263