bscholtes1A commented 2 years ago

What this PR changes/adds

Generate a Gaia-X Self-Description based on a template for each participant and inject it into the associated Identity Hub.

Why it does that

Each dataspace participant should have its own Self-Description.

Linked Issue(s)

186

Checklist

[ ] added appropriate tests?
[ ] performed checkstyle check locally?
[ ] added/updated copyright headers?
[ ] documented public classes/methods?
[ ] added/updated relevant documentation?
[ ] added relevant details to the changelog? (skip with label no-changelog)
[ ] formatted title correctly?

github-actions[bot] commented 2 years ago

Unit Test Results

  7 files ±0   7 suites ±0 43s :stopwatch: +2s 27 tests ±0 26 :heavy_check_mark: ±0 1 :zzz: ±0 0 :x: ±0 30 runs +3 29 :heavy_check_mark: +3 1 :zzz: ±0 0 :x: ±0

Results for commit 8b26d9b0. ± Comparison against base commit 8e1c8802.

This pull request removes 3 and adds 3 tests. Note that renamed tests count towards both.

``` org.eclipse.dataspaceconnector.system.tests.identityhub.IdentityHubIntegrationTest ‑ [1] http://localhost:8181/api/identity-hub, eu org.eclipse.dataspaceconnector.system.tests.identityhub.IdentityHubIntegrationTest ‑ [2] http://localhost:8182/api/identity-hub, eu org.eclipse.dataspaceconnector.system.tests.identityhub.IdentityHubIntegrationTest ‑ [3] http://localhost:8183/api/identity-hub, us ``` ``` org.eclipse.dataspaceconnector.system.tests.identityhub.IdentityHubIntegrationTest ‑ [1] http://localhost:8181/api/identity-hub, eu, FR org.eclipse.dataspaceconnector.system.tests.identityhub.IdentityHubIntegrationTest ‑ [2] http://localhost:8182/api/identity-hub, eu, DE org.eclipse.dataspaceconnector.system.tests.identityhub.IdentityHubIntegrationTest ‑ [3] http://localhost:8183/api/identity-hub, us, US ```

:recycle: This comment has been updated with latest results.

codecov-commenter commented 2 years ago

Codecov Report

Merging #267 (23e61a0) into feature/186-participant-self-description (8e1c880) will not change coverage. The diff coverage is n/a.

@@                             Coverage Diff                             @@
##             feature/186-participant-self-description     #267   +/-   ##
===========================================================================
  Coverage                                       78.78%   78.78%           
  Complexity                                         20       20           
===========================================================================
  Files                                               5        5           
  Lines                                              66       66           
  Branches                                            5        5           
===========================================================================
  Hits                                               52       52           
  Misses                                             14       14

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

bscholtes1A commented 2 years ago

I assume:

integration tests will follow in a next PR?

you have tested manually that this PR produces the expected file

Would be good to answer that in the PR description

I have completed an existing integration test https://github.com/agera-edc/MinimumViableDataspace/pull/267/files#diff-1c16050e7a1661aae3abbf2aec3894483d4b82036dfcb665f3b937760c2f841d, which ensure the file is properly exposed trough the Identity Hub.

@algattik which additional integration test would you foresee? (knowing that Self-Description is only used for display purpose at the time we speak)

agera-edc / MinimumViableDataspace

Add participant self-description #267