Closed bscholtes1A closed 2 years ago
7 files ±0 7 suites ±0 43s :stopwatch: +2s 27 tests ±0 26 :heavy_check_mark: ±0 1 :zzz: ±0 0 :x: ±0 30 runs +3 29 :heavy_check_mark: +3 1 :zzz: ±0 0 :x: ±0
Results for commit 8b26d9b0. ± Comparison against base commit 8e1c8802.
:recycle: This comment has been updated with latest results.
Merging #267 (23e61a0) into feature/186-participant-self-description (8e1c880) will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## feature/186-participant-self-description #267 +/- ##
===========================================================================
Coverage 78.78% 78.78%
Complexity 20 20
===========================================================================
Files 5 5
Lines 66 66
Branches 5 5
===========================================================================
Hits 52 52
Misses 14 14
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
I assume:
- integration tests will follow in a next PR?
- you have tested manually that this PR produces the expected file
Would be good to answer that in the PR description
I have completed an existing integration test https://github.com/agera-edc/MinimumViableDataspace/pull/267/files#diff-1c16050e7a1661aae3abbf2aec3894483d4b82036dfcb665f3b937760c2f841d, which ensure the file is properly exposed trough the Identity Hub.
@algattik which additional integration test would you foresee? (knowing that Self-Description is only used for display purpose at the time we speak)
What this PR changes/adds
Generate a Gaia-X Self-Description based on a template for each participant and inject it into the associated Identity Hub.
Why it does that
Each dataspace participant should have its own Self-Description.
Linked Issue(s)
186
Checklist
no-changelog
)