search

agera-edc / MinimumViableDataspace

Guidance on documentation, scripts and integration steps on using the EDC project results
Apache License 2.0
0 stars 2 forks source link

Prevent Azure resource name clashes #269

Open marcgs opened 2 years ago

marcgs commented 2 years ago

Feature TBD

Description

MVD Deploy workflow can fail as the Azure resource naming is not unique across repository forks/branches.

Sample run on MVD main repository with error message "The storage account named mvd83dataspacedid is already taken" and "The storage account named mvd83gaiaxdid is already taken".

cloud-cd.yaml indicates:

# Update this value with a unique name to guarantee uniqueness of resource names and avoid conflicts between fork repositories when running CD workflow.
# CD workflow creates resources with this prefix and destroy them.
env:
  CD_RESOURCES_PREFIX: mvd

But it seems this is not enough to prevent all kinds of clashes

Acceptance Criteria

Tasks

algattik commented 2 years ago

Multiple solutions are possible, decided to use the reversed prefix as a GitHub secret as the simplest solution for now.