algattik commented 2 years ago

What this PR changes/adds

Make the Azure resource prefix a GitHub secret (as a reversed string).

Why it does that

Avoid collisions between resources deployed in multiple forks (assuming forkers select different prefixes). The previous mechanism was through changing a value in a YAML file - that was inconvenient as

forkers would forget to do it
this creates a spurious commit in the history, making contribs more complex

Further notes

The reason the prefix is stored as a reversed string is to avoid the value being excluded from GitHub job outputs.

The prefix should be non-palindromic. I considered adding that requirement in the README file, but it seemed to make the text a bit too complex.

Linked Issue(s)

https://github.com/agera-edc/MinimumViableDataspace/issues/269

Checklist

[ ] added appropriate tests?
[ ] performed checkstyle check locally?
[ ] added/updated copyright headers?
[ ] documented public classes/methods?
[ ] added/updated relevant documentation?
[ ] added relevant details to the changelog? (skip with label no-changelog)
[ ] formatted title correctly?

github-actions[bot] commented 2 years ago

Unit Test Results

  7 files ±0   7 suites ±0 35s :stopwatch: -8s 27 tests ±0 26 :heavy_check_mark: ±0 1 :zzz: ±0 0 :x: ±0 30 runs ±0 29 :heavy_check_mark: ±0 1 :zzz: ±0 0 :x: ±0

Results for commit 94da9384. ± Comparison against base commit adb74333.

:recycle: This comment has been updated with latest results.

codecov-commenter commented 2 years ago

Codecov Report

Merging #270 (5eab935) into bug/269-cd-resource-name-prefix (adb7433) will not change coverage. The diff coverage is n/a.

@@                        Coverage Diff                         @@
##             bug/269-cd-resource-name-prefix     #270   +/-   ##
==================================================================
  Coverage                              78.78%   78.78%           
  Complexity                                20       20           
==================================================================
  Files                                      5        5           
  Lines                                     66       66           
  Branches                                   5        5           
==================================================================
  Hits                                      52       52           
  Misses                                    14       14

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

agera-edc / MinimumViableDataspace

Bug/269/269 cd resource name prefix #270