Closed bscholtes1A closed 1 year ago
github-actions[bot]
commented
2 years ago 7 files 7 suites 45s :stopwatch: 28 tests 27 :heavy_check_mark: 1 :zzz: 0 :x: 31 runs 30 :heavy_check_mark: 1 :zzz: 0 :x:
Results for commit e9965cf1.
:recycle: This comment has been updated with latest results.
codecov-commenter
commented
2 years ago :exclamation: No coverage uploaded for pull request base (
feature/187-did-document-link-to-self-description@737d558). Click here to learn what that means. The diff coverage isn/a.
@@ Coverage Diff @@
## feature/187-did-document-link-to-self-description #278 +/- ##
====================================================================================
Coverage ? 78.78%
Complexity ? 20
====================================================================================
Files ? 5
Lines ? 66
Branches ? 5
====================================================================================
Hits ? 52
Misses ? 14
Partials ? 0 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
bscholtes1A
commented
1 year ago nit: do we need maybe a decision record describing the Self description document usage in MVD? I see there's an ADR in IdentityHub repo but I wonder if it would be useful to have also one in the MVD context
not sure this is relevant, as the self-description is not used in the MVD, except for display purposes.
What this PR changes/adds
This PR adds a reference to the Self-Description endpoint exposed by the Identity Hub in all DID documents (participants + authority).
Why it does that
DID document should reference all service endpoints that can be targeted externally, which includes the Self-Description endpoint.
Linked Issue(s)
187
Checklist
no-changelog)