agerada / AIgarMIC

AIgarMIC – machine-learning assisted agar dilution software
GNU General Public License v3.0
2 stars 2 forks source link

Grids other than 96 crashing #25

Open agerada opened 1 week ago

agerada commented 1 week ago

Reported by Bree Garey.

AIgarMIC has not undergone extensive testing with grids other than 96 (8 x 12).

Error with find_threshold, only expects 96 grid.

@yinzheng-zhong this will impact front-end development.

yinzheng-zhong commented 1 week ago

I am expecting to start sending images to the backend tomorrow so I can have a look at this as well.

agerada commented 1 week ago

Hopefully this should fix but need to add some tests for non-96 grid images fd0c64397068268e46d0bf7646a8ee1314a38900

agerada commented 1 week ago

29 Additional bug prevented main.py script from working. Patched in https://github.com/agerada/AIgarMIC/releases/tag/v1.1.1

Removed default arguments for grid shape in internal functions.

Main.py script currently still has a default 8 x 12 grid dimensions. Add exception handler for cases where find_threshold returns None. Prompt user to double check -d parameter.