search

agermanidis / SnapchatBot

[deprecated] Python library for building bots that live on Snapchat
MIT License
518 stars 105 forks source link

Process stories function #41

Closed enstulen closed 9 years ago

enstulen commented 9 years ago

You're using a function that you removed with the latest commit "unused function" in bot.by. return self.process_stories(stories)

I used your previous commit where this function was declared and it works, but it goes through every single one:

[2015-03-13 16:37:44,271] "GET /bq/story_blob?story_id=5155449636847616 HTTP/1.1" 200 247952 [2015-03-13 16:37:45,388] Starting new HTTPS connection (1): feelinsonice-hrd.appspot.com [2015-03-13 16:37:45,892] "GET /bq/story_blob?story_id=5206986291609600 HTTP/1.1" 200 260496 [2015-03-13 16:37:46,517] Starting new HTTPS connection (1): feelinsonice-hrd.appspot.com [2015-03-13 16:37:46,859] "GET /bq/story_blob?story_id=6025635613048832 HTTP/1.1" 200 261040 [2015-03-13 16:37:47,900] Starting new HTTPS connection (1): feelinsonice-hrd.appspot.com

With a large number of snaps, this is really slow. Is there any other way to do this?

agermanidis commented 9 years ago

Oops, brought it back.

The bot does individual calls for every story because that's the only way to get the data for that story. I can make it optionally not grab the data though if that would help.

enstulen commented 9 years ago

That would be nice :) I just need the length and to be able to delete the ones that have been on the story the longest time.

agermanidis commented 9 years ago

Cool. Can you make a pull request?

You will need to make that conditional: https://github.com/agermanidis/SnapchatBot/blob/cb9c0783b68583e542ef7da71c39b4285873393a/snapchat_bots/bot.py#L168-L170

and change a few things on snap.py to make it OK to not have any data.

Thanks.

enstulen commented 9 years ago

I’m going out now, but I’ll definitely look at it tomorrow. Thanks! :)

  1. mar. 2015 kl. 17.14 skrev Anastasis Germanidis notifications@github.com:

Cool. Can you make a pull request?

You will need to make that conditional: https://github.com/agermanidis/SnapchatBot/blob/cb9c0783b68583e542ef7da71c39b4285873393a/snapchat_bots/bot.py#L168-L170 https://github.com/agermanidis/SnapchatBot/blob/cb9c0783b68583e542ef7da71c39b4285873393a/snapchat_bots/bot.py#L168-L170 and change a few things on snap.py to make it OK to not have any data.

Thanks.

— Reply to this email directly or view it on GitHub https://github.com/agermanidis/SnapchatBot/issues/41#issuecomment-79088362.