search

ageron / handson-ml

⛔️ DEPRECATED – See https://github.com/ageron/handson-ml3 instead.
Apache License 2.0
25.22k stars 12.91k forks source link

Book page 85 missing code #31

Closed julianpraxis closed 7 years ago

julianpraxis commented 7 years ago

This code is in cell [22] of the notebook but does not appear on page 85 of the book. y_train_perfect_predictions = y_train_5

@ageron What is the best way to let you know of items such as this one? I am going through the book in a very methodical, slow manner; hence, I might find things that you might want to know about.

Praveen-Gupta commented 7 years ago

There is one errata page mentioned at book URL page. This one is already mentioned there. Check http://www.oreilly.com/catalog/errata.csp?isbn=0636920052289

On 5 Jun 2017 11:27 p.m., "Julian" notifications@github.com wrote:

This code is in cell [22] of the notebook but does not appear on page 85 of the book. y_train_perfect_predictions = y_train_5

@ageron https://github.com/ageron What is the best way to let you know of items such as this one? I am going through the book in a very methodical, slow manner; hence, I might find things that you might want to know about.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/ageron/handson-ml/issues/31, or mute the thread https://github.com/notifications/unsubscribe-auth/AE1laxKumwlSrcO-rvA2UeJS8JzkUYQEks5sBEGRgaJpZM4NwXQz .

julianpraxis commented 7 years ago

@Praveen-Gupta OK. Thank you. I will report "errors" I find in the book to the book's page at O'Reilly.

ageron commented 7 years ago

Thanks for your feedback @julianpraxis, and thanks @Praveen-Gupta for the helpful link.

For problems concerning the notebooks, filing a GitHub issue is the best option. For problems concerning the book, then the errata page that Praveen pointed to is the best option.

You'll find lots of content in the notebook that does not appear in the book. In general, it is on purpose, because the text explains something, and I want to keep the code as concise as possible, for readability. I understand that people may wonder where these "perfect predictions" come from, but if I write "y_train_perfect_predictions = y_train_5" I'm afraid other people may wonder why I'm writing this? The idea was that a perfect model, if you can train one, will give you a diagonal confusion matrix.

Hope this helps, Aurélien