search

ageron / handson-ml3

A series of Jupyter notebooks that walk you through the fundamentals of Machine Learning and Deep Learning in Python using Scikit-Learn, Keras and TensorFlow 2.
Apache License 2.0
7.44k stars 3k forks source link

[IDEA] Consider changing variable name in chapter 5 notebook #120

Closed tandao0909 closed 8 months ago

tandao0909 commented 8 months ago

In the code cells you generated to solve the final exercise in chapter 5's notebook, I notice that you use svm_clf for the pipeline consists of SVR. I think it will be better if you rename it to svm_reg, as this is a pipeline for regression task, not classfication.
I suggest this because I think you follow the convention to name a pipeline *_reg for a regression pipeline and *_clf for a classification pipeline. Please clarify me if I understand it wrong.

ageron commented 8 months ago

Good catch, thanks @tandao0909 ! Indeed, it was a copy&paste error, it should have been svm_reg, not svm_clf in that exercise. 👍